Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventSignup endpoint and new getAllReservations EventService method. #771

Merged

Conversation

jeffplays2005
Copy link
Contributor

Created new eventSignup endpoint and their controller.

Takes in a EventSignupBody and returns an EventSignupResponse.

Created EventService getAllReservations method and test.

Created new eventSignup endpoint and their controller.

Takes in a EventSignupBody and returns an EventSignupResponse.

Created EventService `getAllReservations` method and test.
@jeffplays2005 jeffplays2005 linked an issue Sep 1, 2024 that may be closed by this pull request
6 tasks
@jeffplays2005
Copy link
Contributor Author

Will create tests in an upcoming commit

Copy link

github-actions bot commented Sep 1, 2024

Visit the preview URL for this PR (updated for commit c424bbc):

https://uasc-ceebc--pr771-688-backend-create-e-bop3v2bk.web.app

(expires Mon, 09 Sep 2024 05:04:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

* Removes requirement for JWT in the endpoint.

* Checks if `max_occupancy` is undefined and **only** compares occupancy if `max_occupancy` isn't undefined.
Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffplays2005 jeffplays2005 merged commit 346a959 into master Sep 2, 2024
8 checks passed
@jeffplays2005 jeffplays2005 deleted the 688-backend-create-endpoint-for-user-to-sign-up-to-event branch September 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BACKEND] Create endpoint for user to sign up to event
2 participants